Make the output reproducible. #1048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0], we noticed that yardoc generates output that is not reproducible due to the use of a fallback glob that relies on (non-deterministic) filesystem ordering. [0] https://reproducible-builds.org/ Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
|
You would have to sort the globs, not the entire list. One of YARD's features is allowing manual ordering of the source list. |
|
(This is also filed in Debian as https://bugs.debian.org/849972) |
Well, surely expand the default glob and sort only that, not sort the glob itself? ;) |
Yes, I meant that. Also note that it is already being sorted, but by length-- that has to stick around too. |
|
Ah, interesting. My Ruby isn't that great alas - would a patch be easy for you to prepare? Happy to test it. |
|
Sure. If you close this and open an issue for the bug we can track it there. |
|
Closing as requested in favour of #1049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort [0], we noticed
that yardoc generates output that is not reproducible due to the
use of a fallback glob that relies on (non-deterministic)
filesystem ordering.
[0] https://reproducible-builds.org/
Signed-off-by: Chris Lamb chris@chris-lamb.co.uk
Description
Describe your pull request and problem statement here.
Completed Tasks
bundle exec rakelocally (if code is attached to PR).