Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-languages support #7

Closed
cniweb opened this issue Apr 26, 2016 · 5 comments
Closed

Add multi-languages support #7

cniweb opened this issue Apr 26, 2016 · 5 comments

Comments

@cniweb
Copy link

cniweb commented Apr 26, 2016

We use the plugin to generate EJB stubs in the build process.

We have a German Websphere Application Server installed on a German Windows OS, so the command line output works also on German.

In plugin but queried on the English edition, which is why the build job fails, even though the EJB stub is generated successfully.

See Line 172:
https://github.com/lsiu/websphere-maven-plugin/blob/master/websphere-maven-plugin/src/main/java/com/github/lsiu/maven/plugin/websphere/CreateEjbStubsMojo.java#L172

Please Check the return code or add multi-languages support.

Thanks,
Chris

@lsiu
Copy link
Owner

lsiu commented Apr 27, 2016

Unfortunately, it appears the exit code of createEJBStubs.bat/sh always return 0 back when I build this, hence the check for "Command Successful" output to the console.

If you can give me what the German WebSphere createEJBStubs.bat/sh outputs on success , I can just add it to the check as well.

@cniweb
Copy link
Author

cniweb commented Jun 3, 2016

Hi @lsiu,

the text is: Befehl erfolgreich

Thanks,
Chris

@lsiu
Copy link
Owner

lsiu commented Jul 24, 2016

Hi @cniweb,

Thanks for the text. Unfortunately, I don't work with WebSphere so I can't really test this. I did incorporate the check for the text Befehl erfolgreich in commit ed89189 and pushed 1.1.2-SNAPSHOT to maven central snapshot repository.

Do let me know if it works for you. If it does, I can safely push it to maven central release repository.

@cniweb
Copy link
Author

cniweb commented Oct 7, 2016

Hi @lsiu,

the PR looks good!
Release, please.

Chris

@lsiu
Copy link
Owner

lsiu commented Oct 10, 2016

Version 1.1.2 released. It may take a few hours to sync to maven central.

@lsiu lsiu closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants