Move service "movieAddHandler" logic to the manager package

[lsmoura]

No description provided.

[thevibhu]

I would like to take up this issue @lsmoura !

[lsmoura]

Sure! Go ahead!!

[thevibhu]

Just to be sure, do I have to only move movieAddHandler method from package service to package manager, or do I have to move other methods as well? After I am done, how can I test my code/changes?

[lsmoura]

Just this one method is fine. The move is actually the first step to make code testable and I’ll write tests next week.

If you want to run the service and call api endpoints using curl, you can do so, but you need some api keys (you can see the env variables on the cmd folder).

You can just make the PR to the best of your ability and I can do some manual testing.

[thevibhu]

Just moving one method to the manager package is making some code repeating or an import cycle as movieAddHandler method has Config value receiver. This can be solved, but to solve the import cycle I have to repeat the Config struct in both packages and still have issues when calling the methods in the main and service file. I think moving other methods as well in the manager package will be better and we can comment on the code in the movie.go as of now. What do you suggest?

[lsmoura]

The idea is to remove the service dependency on the database, sabnzbd and tmdb services. I'm ok with having code duplication until all the methods are moved.

The manager package should not be dependent on the config package. For now, we can pass the required values to the manager function as parameters and then phase out the parameter requirements once the manager has everything it needs, and eventually remove the service dependency from other packages except for the manager and chi.