PelEntryVersion::setValue raises PHP warning in PHP 7.1 #74
Conversation
when the $version parameter passed is non numeric: _A non-numeric value encountered_
|
My solution for this issue looks like this: svenbluege@1fa9787 What is the best way to fix this? |
|
I think an exception should be thrown in the case of illegal parameters to show the user/developer something is wrong here. |
|
This would just change the notice to an exception. So the question is still if we should fix the invalid call to the parent constructor or/and the handling of the data in the PelEntryVersion::setValue method.. |
|
Just note that this is currently occurring within PEL during the file loading process, not (necessarily) in calls from outside code. In other words: PEL raises notices when run in PHP 7.1+. See https://travis-ci.org/lsolesen/pel/jobs/188751705 where the master branch is run against PHP nightly. This is causing failures also in Drupal testing of the File Metadata Manager module (see #73). |
* Added PHP 7.1 support * Do not longer test against PHP 5.5 but PHP 5.6+ * PelEntryVersion does no longer base on PelEntryUndefined but on PelEntry; this makes it working on PHP 7.1 and should speed up the code a little bit (fix for #74) * Fixed and improved PhpDoc * Updated phpcs to version 3.0.0beta
|
Please test the current master version. The issue should be fixed now. |
|
Confirmed, thank you. |
when the $version parameter passed is non numeric:
A non-numeric value encountered