Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-17441: Modernize ATDome simulator and make it the real CSC #2

Merged
merged 11 commits into from Feb 6, 2019

Conversation

r-owen
Copy link
Collaborator

@r-owen r-owen commented Feb 5, 2019

No description provided.

Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I see no problems upon review.

Add the `run_command` method and use a lock to prevent collisions.
Add tests for:

* The bin script
* The settingsAppliedDomeTcp event
* The individual door commands
Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved later changes as well.

@r-owen r-owen merged commit 63e5b27 into develop Feb 6, 2019
@r-owen r-owen deleted the tickets/DM-17441 branch February 6, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants