New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-17441: Modernize ATDome simulator and make it the real CSC #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still have to make more changes to the unit tests
and update the documentation accordingly.
couger01
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I see no problems upon review.
r-owen
force-pushed
the
tickets/DM-17441
branch
from
February 5, 2019 23:12
dc4911d
to
5ad81fb
Compare
r-owen
force-pushed
the
tickets/DM-17441
branch
from
February 5, 2019 23:14
5ad81fb
to
50361bf
Compare
Add the `run_command` method and use a lock to prevent collisions.
Add tests for: * The bin script * The settingsAppliedDomeTcp event * The individual door commands
r-owen
force-pushed
the
tickets/DM-17441
branch
from
February 5, 2019 23:16
50361bf
to
b6acc32
Compare
couger01
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved later changes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.