Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-22066: fix issues found with rotator testing at SLAC #7

Merged
merged 11 commits into from Nov 12, 2019

Conversation

r-owen
Copy link
Collaborator

@r-owen r-owen commented Nov 2, 2019

No description provided.

@r-owen r-owen changed the title DM-22066: fix issues found with SLAC testing DM-22066: fix issues found with rotator testing at SLAC Nov 2, 2019
@r-owen r-owen force-pushed the tickets/DM-22066 branch 5 times, most recently from d8ec245 to b279493 Compare November 6, 2019 23:57
@r-owen r-owen force-pushed the tickets/DM-22066 branch 9 times, most recently from d41ba69 to 087c3ee Compare November 8, 2019 01:09
@r-owen r-owen requested a review from teweitsai November 8, 2019 18:26
Copy link
Contributor

@teweitsai teweitsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor of code looks good. Most of duplicated code are moved to ts_hexrotcomm. Well done!

@r-owen r-owen merged commit 00e19f5 into develop Nov 12, 2019
@r-owen r-owen deleted the tickets/DM-22066 branch November 12, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants