Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip: keys are taken from the first array #108

Closed
Erikvv opened this issue Oct 21, 2016 · 3 comments
Closed

zip: keys are taken from the first array #108

Erikvv opened this issue Oct 21, 2016 · 3 comments

Comments

@Erikvv
Copy link
Contributor

Erikvv commented Oct 21, 2016

I would expect it to look in all arrays like it does in lodash. And fill the missing indexes with null like it does now.

I can provide a fix if you want, or maybe we can define another function, maybe 'zipLongest'

@lstrojny
Copy link
Owner

Sounds indeed like a bug/oversight when implementing the original function. Happy to have a fix for it.

@krtek4
Copy link
Contributor

krtek4 commented Oct 25, 2016

Actually zip has various implementation regarding this in multiple languages.

So I would say it is more of a chose a side kind of thing :P

@lstrojny
Copy link
Owner

OK, I am convinced. I changed my mind. Let’s add a zip_all() function (or some other name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants