New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ary
function which ignores arguments over the supplied number
#215
Conversation
In lodash this function is called |
Maybe |
I would just follow lodash‘s naming precedence |
ignore_args
which ignores arguments over the supplied numberary
function which ignores arguments over the supplied number
@lstrojny Renamed the function and added tests (the build fail seems to be unrelated and fixed by my other PR) |
Care to document the function in the docs as well? |
@lstrojny added documentation to the tests commit. |
Added function which defines a function of an arbitry number of arguments and calls the provided callable with only the given number of arguments As suggested by @lstrojny, using the name `ary`, like in https://lodash.com/docs/4.17.15#ary
Great, thank you! One last thing, can you check https://travis-ci.org/github/lstrojny/functional-php/jobs/691301121 and fix the coding style errors, then we are ready to merge this |
How does it check those? I ran php-cs-fixer (from vendor/bin) and it didn't fiz it |
That PHP code sniffer. Run |
Ok, should be ready to merge, now |
Great, thank you! |
Added function which defines a function of an arbitry number of arguments and
calls the provided callable with only the given number of arguments
Didn't add tests as it wasn't obvious how they worked and wanted feedback before investing the time