Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package details #27

Closed
sagikazarmark opened this issue Jan 28, 2015 · 2 comments
Closed

Package details #27

sagikazarmark opened this issue Jan 28, 2015 · 2 comments

Comments

@sagikazarmark
Copy link
Contributor

Some package improvements I would do:

  • Add a .editorconfig file for making compatible IDEs follow conventions.

Sample content:

root = true

[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[composer.json]
indent_style = space
indent_size = 4

[*.php]
indent_style = space
indent_size = 4

[*.yml]
indent_style = space
indent_size = 2
  • Add a .scrutinizer.yml file, to customize tests and ignore tests/ directory.

Sample content:

filter:
  paths: [src/*]
tools:
  php_analyzer: true
  php_mess_detector: true
  php_pdepend: true
  external_code_coverage:
    timeout: '600'
  • Add code coverage upload in travis using ocular.

Sample content:

language: php

php:
  - 5.4
  - 5.5
  - 5.6
  - hhvm

before_script:
  - travis_retry composer self-update
  - travis_retry composer install --prefer-source --no-interaction
  - npm install

script: phpunit

after_script:
  - if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then wget https://scrutinizer-ci.com/ocular.phar; fi
  - if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml; fi

(Of course it needs a phpunit configuration generating coverage)

If you like any of these, I am happy to open a PR.

@lstrojny
Copy link
Owner

Sure, go ahead, looking forward to it!

@sagikazarmark
Copy link
Contributor Author

Closed by #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants