Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6MB XML file #68

Closed
laurent22 opened this issue Jul 11, 2017 · 2 comments
Closed

6MB XML file #68

laurent22 opened this issue Jul 11, 2017 · 2 comments

Comments

@laurent22
Copy link

The benchmark folder includes a 6 MB XML file, is it really necessary to include this in the composer package?
@lstrojny
Copy link
Owner

Indeed, that would be better not included in the releases. @laurent22 do you happen to know if composer’s excludes are enough?

@sagikazarmark
Copy link
Contributor

A commonly accepted way is adding an export-ignore entry to .gitattributes. Composer downloads git archives generated by Github when used with the --dist option.

@sagikazarmark sagikazarmark mentioned this issue Feb 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lstrojny @sagikazarmark @laurent22