Projected final is broken in beta

[rrusso]

Use http://beta.moodle.lsu.edu/course/view.php?id=40 to test.

Click grades > projected final.

Click any student and fill in data.

For bonus points, do the above in Firefox!

[philcali]

Here's the problem code: https://github.com/lsuits/projected-final-grade/blob/master/rpc.php#L388

Instead of using the mocked category item, pull the grade item from the db like: grade_item::fetch(array('itemtype' => 'category', ...));

Replace the second params with the result of that invocation.

[rrusso]

Are we going with this or Adam's?

I need to push soon.

[adamzap]

Robert, please test. The fix is on master.

[rrusso]

Still getting notices:

Notice: Undefined index: 2 in /var/www/rrusso/22/grade/report/projected/rpc.php on line 370 Notice: Undefined index: in /var/www/rrusso/22/grade/report/projected/rpc.php on line 370 Notice: Trying to get property of non-object in /var/www/rrusso/22/grade/report/projected/rpc.php on line 370 Notice: Undefined index: 2 in /var/www/rrusso/22/grade/report/projected/rpc.php on line 370 Notice: Undefined index: in /var/www/rrusso/22/grade/report/projected/rpc.php on line 370 Notice: Trying to get property of non-object in /var/www/rrusso/22/grade/report/projected/rpc.php on line 370 Notice: Undefined index: 2 in /var/www/rrusso/22/grade/report/projected/rpc.php on line 374 Notice: Undefined index: in /var/www/rrusso/22/grade/report/projected/rpc.php on line 374 Notice: Trying to get property of non-object in /var/www/rrusso/22/grade/report/projected/rpc.php on line 374 Notice: Undefined index: 2 in /var/www/rrusso/22/grade/report/projected/rpc.php on line 375 Notice: Undefined index: in

[adamzap]

Could you send me the course you are testing with?

[rrusso]

It was just a generic blank course that I created a gradebook with the builder.

[rrusso]

This can take a backseat to the restore issue.

[adamzap]

A new fix is on master, so this is ready for testing again.

[rrusso]

Does not work (nothing happens when grades are typed int) in the following configuration:

COURSE -> sum of grades -> 1000 pts

• TESTS - > sum of grades -> 700 pts
  • Test 1 -> 100 pts
  • Test 2 -> 200 pts
  • Test 3 -> 100 pts
  • Test 4 -> 200 pts
  • Test 5 -> 100 pts
• Quizzes -> Simple Weighted Mean of grades -> 200 pts
  • Quiz 1 -> 20 pts
  • Quiz 2 -> 20 pts
  • Quiz 3 -> 20 pts
  • Quiz 4 -> 20 pts
  • Quiz 5 -> 10 pts
  • Quiz 6 -> 10 pts
  • Quiz 7 -> 20 pts
• Homework - > Simple Weighed Mean of grades -> 100 pts
  • Homework 1 -> 1 pt
  • Homework 2 -> 1 pt
  • Homework 3 -> 1 pt
  • Homework 4 -> 1 pt
  • Homework 5 -> 1 pt
  • Homework 6 -> 1 pt
  • Homework 7 -> 1 pt
  • Homework 8 -> 1 pt
  • Homework 9 -> 1 pt
  • Homework 10 -> 1 pt
  • Homework 11 -> 1 pt
  • Homework 12 -> 1 pt
  • Homework 13 -> 1 pt
  • Homework 14 -> 1 pt

[adamzap]

Could you send me this course to debug with?

[rrusso]

No.

It takes WAY less time to build with the GB builder than to restore it.

That's how I created it anyway. Nothing special.

[adamzap]

Ok, that problem should be fixed.

I think these are all unrelated issues...

On that course, a perfect score of 1,000 is formatted as 1.00 for some reason. It may be due to an internal hard-coded limit in Moodle core, but we'll look into it. That enough of an edge case to ignore for now.

[rrusso]

Same course as above, must make shows 0 to make an A when an A is not a possible grade.

Enter the following values to reproduce:
COURSE (SUM) aggregate only non-empty)

• TESTS - > sum of grades aggregate only non-empty -> drop lowest 1 (works now)
  • Test 1 -> 100 pts
  • Test 2 -> 160 pts
  • Test 3 -> 80 pts
  • Test 4 -> 200 pts
  • Test 5 -> EMPTY (last one) pts
• Quizzes -> Simple Weighted Mean of grades -> 200 pts
  • Quiz 1 -> 20 pts
  • Quiz 2 -> 16 pts
  • Quiz 3 -> 16 pts
  • Quiz 4 -> 20 pts
  • Quiz 5 -> 8 pts
  • Quiz 6 -> 10 pts
  • Quiz 7 -> 18 pts
• Homework - > Simple Weighed Mean of grades -> 100 pts (drop lowest 4)
  • Homework 1 -> 1 pt
  • Homework 2 -> 1 pt
  • Homework 3 -> 1 pt
  • Homework 4 -> 1 pt
  • Homework 5 -> 1 pt
  • Homework 6 -> 0 pt
  • Homework 7 -> 0 pt
  • Homework 8 -> 0 pt
  • Homework 9 -> 0 pt
  • Homework 10 -> 1 pt
  • Homework 11 -> 0 pt
  • Homework 12 -> 0 pt
  • Homework 13 -> 0 pt
  • Homework 14 -> 1 pt

[adamzap]

I found a few more underlying problems due to changes in the grade system. I think I'm close to fixing this, but I may find more.

Projected Final Grade really needs to be rewritten from scratch.

[rrusso]

We can add that to our list of ever growing things to do.

[adamzap]

A new fix is on master...this should be the one.

[rrusso]

Issues still occurring:

1. When using drop lowest in SUM category total in PFG is less than category total in gradebook
2. Some SUM category totals do not update
3. SUM category totals show ?? after erros have been cleared

How to replicate:

1. Create SUM category -> add more than two grades (100, 80, 70...cat total is 250) -> drop lowest 1 (cat total drops to 180) -> check PFG (cat total goes up to 100 MAX)
2. Come see me to replicate, very weird.
3. Come see me to replicate, very weird. Related to the above.

[adamzap]

1 Should be fixed. Let me know if 2 and 3 are still happening.

[rrusso]

2 and 3 are still broken.

[adamzap]

I think it's finally fixed.

[rrusso]

Yes it is!