fix resending mail requests (#401) #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coudot
reviewed
Jul 25, 2024
| # Generate formtoken | ||
| ini_set("session.use_cookies",0); | ||
| ini_set("session.use_only_cookies",1); | ||
| ini_set("session.use_strict_mode",0); |
There was a problem hiding this comment.
We use ini_set in a lot of places in our code, and here in this page.
Maybe we should move them to index.php?
There was a problem hiding this comment.
Good point!
Maybe at some point we would need to have cookies sent for saving the session at client side. So, I am rather thinking to a dedicated function.
Also I am not quite satisfied by calling ini_set, whereas:
- there are some warning in debug mode about misusage of ini_set function
- it seems you can set those parameters in the session_start function (but my tests don't work for now)
There was a problem hiding this comment.
Yes, using php session mechanism was an easy way to deal with tokens, but we may find a better solution. It will require a token backend on server side, which should be something easy to set up (files, in memory base, ...)
| } | ||
|
|
||
| #============================================================================== | ||
| # Send token by mail | ||
| #============================================================================== | ||
| if ( !$result ) { | ||
|
|
||
|
|
There was a problem hiding this comment.
Was it intentional to add this blank line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401