Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search functionality #8

Open
ftomassetti opened this issue Mar 27, 2014 · 10 comments
Open

Search functionality #8

ftomassetti opened this issue Mar 27, 2014 · 10 comments
Milestone

Comments

@ftomassetti
Copy link
Collaborator

The ability to search over all the fields of patches

@ftomassetti ftomassetti added this to the v1.0 milestone Oct 23, 2015
@ftomassetti ftomassetti mentioned this issue Oct 26, 2015
@ftomassetti
Copy link
Collaborator Author

For this one we have a patch pending

@lu-zero
Copy link
Owner

lu-zero commented Nov 7, 2015

Your patch is filtering using python and doesn't paginate (major sin).

So far it searches by project and by name.

@ftomassetti
Copy link
Collaborator Author

Yes, it is filtering in python also because text search in SQL depends on the different engine implementations. I am not sure how the ORM deals with that. Given the size of data involved I think it is reasonable and we have an implementation ~1.5 years after the issue was opened but I will not prevent someone else to come up with a better solution :)

@lu-zero
Copy link
Owner

lu-zero commented Nov 7, 2015 via email

@ftomassetti
Copy link
Collaborator Author

Great!

@ftomassetti
Copy link
Collaborator Author

Should we close this one? I will take a look to learn something :)

@lu-zero
Copy link
Owner

lu-zero commented Nov 7, 2015 via email

@lu-zero
Copy link
Owner

lu-zero commented Nov 8, 2015

the whoosh integration with sqlalchemy I was using is too brittle.

@lu-zero
Copy link
Owner

lu-zero commented Nov 8, 2015

Found a working version but this dhamaniasad/Flask-WhooshAlchemy#4 is missing.

@ftomassetti
Copy link
Collaborator Author

Should we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants