Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installable app support #4

Closed
maxence-charriere opened this issue Jul 11, 2020 · 11 comments
Closed

installable app support #4

maxence-charriere opened this issue Jul 11, 2020 · 11 comments

Comments

@maxence-charriere
Copy link

Hey, I'm the creator of go-app.

I was thinking that it would be cool to have this available as an installable app. I updated the package version to v7.0.3 and it makes it possible with GitHub Pages hosted apps.

You would just have to update go-app and push it to your repo.

Also, since your app is white, you may want to tweak the handler by specifying a white theme color:

app.Handler{
    // ...
    ThemeColor: "#ffffff",
}

Best,
Maxence

@maxence-charriere
Copy link
Author

You may also want to put your own logo since the default one will be go-app logo.

app.Handler{
    ThemeColor: "#ffffff",
    Icon: app.Icon{
          Default: "/web/YOUR_ICON.png",
    },
}

@lu4p
Copy link
Owner

lu4p commented Jul 11, 2020

Updated to 7.0.3.
I don't have a logo, so I will keep using the default one.
Will apply themecolor tweak.

@maxence-charriere
Copy link
Author

Awesome.
I think you also have to re-generate your static files.

@lu4p
Copy link
Owner

lu4p commented Jul 11, 2020

@maxence-charriere Yes I just realized that

@lu4p
Copy link
Owner

lu4p commented Jul 11, 2020

I applied the suggested tweak, and also tried to set the background color, but the loading screen is still dark.

	h := &app.Handler{
		Name:            "astextract",
		Title:           "astextract",
		BackgroundColor: "#ffffff",
		ThemeColor:      "#ffffff",
		Author:          "lu4p",
		Styles:          []string{"https://unpkg.com/spectre.css/dist/spectre.min.css"},
	}

Or what is the purpose of the theme color?

@lu4p
Copy link
Owner

lu4p commented Jul 11, 2020

Regenerated files are now live. So the app can be installed with mobile browsers.

@maxence-charriere
Copy link
Author

maxence-charriere commented Jul 11, 2020

When you install on chrome on desktop, the windows bar color can be customized:
Screen Shot 2020-07-11 at 7 14 48 PM

// The theme color for the application. This affects how the OS displays the
// app (e.g., PWA title bar or Android's task switcher).
//
// DEFAULT: #2d2c2c.
ThemeColor string

for the loading screen, you can overload the color with css:

.goapp-app-info {
    color: black;
    background-color: white;
}

@lu4p
Copy link
Owner

lu4p commented Jul 11, 2020

Ok thanks.

@lu4p
Copy link
Owner

lu4p commented Jul 11, 2020

@maxence-charriere Set the themecolor to white now.

@lu4p lu4p closed this as completed Jul 11, 2020
@lu4p
Copy link
Owner

lu4p commented Jul 13, 2020

@maxence-charriere When do you plan to put this tool into the live section?

@maxence-charriere
Copy link
Author

it is now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants