Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer values bad read #24

Closed
xmorave2 opened this issue Mar 4, 2016 · 2 comments
Closed

Integer values bad read #24

xmorave2 opened this issue Mar 4, 2016 · 2 comments

Comments

@xmorave2
Copy link
Contributor

xmorave2 commented Mar 4, 2016

Hello,

I have some DBF files from Foxpro, and i faced issue with bad reading integer files.

In Record.php method getIndex should read the integer, but return bad value for me...
According to this documentation, the "I" type of column should be Integer, is it what you mean by "Index"?
For me the "I" type should be read like this:

public function getIndex($columnName) {
    $su = unpack("i", $s);
    return $su[1];
}

I could open a pull request, but I want to know someone else's opinion and also I want to know the original intence of this method.

@xmorave2
Copy link
Contributor Author

xmorave2 commented Mar 8, 2016

I just opened the pull request: #26

@xmorave2
Copy link
Contributor Author

xmorave2 commented Mar 8, 2016

As the pull request is merged, I'm closing this issue

@xmorave2 xmorave2 closed this as completed Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant