Support for Webkit2gtk 4.1 and libsoup 3 #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0dev0id
commented
Jan 24, 2023
There was a problem hiding this comment.
Looks pretty good already and all unit tests pass. I have to reread the issue again to undestand what's going on with the password GET_PROP. But it works.
The --version output looks a bit excessive now. But that's fine for me if the numbers will help to solve problems.
aidanholm
approved these changes
Jan 25, 2023
Co-authored-by: Tao Nelson <taobert@gmail.com>
c0dev0id
force-pushed
the
webkit2gtk-4.1
branch
from
e95e1bc
to
7508440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@taobert worked on the Webkit2gtk 4.1 support, which requires luakit to migrate to libsoup 3.0.
Issue: #1025
The migration steps are mostly documented here:
https://libsoup.org/libsoup-3.0/migrating-from-libsoup-2.html
This PR is to gather feedback, clean up the code a bit and then hopefully merge it relatively soon.