Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kotlin-gradle-plugin at android/build.gradle #723

Merged
merged 1 commit into from Jan 8, 2021
Merged

Add kotlin-gradle-plugin at android/build.gradle #723

merged 1 commit into from Jan 8, 2021

Conversation

koji-1009
Copy link
Contributor

Thanks for the great library!

fix #718

kivancg
kivancg approved these changes Jan 7, 2021
View reviewed changes
Copy link

@kivancg kivancg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayliverified rayliverified mentioned this pull request Jan 7, 2021
Closed
MATTYGILO
MATTYGILO approved these changes Jan 8, 2021
View reviewed changes
Copy link

@MATTYGILO MATTYGILO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

MATTYGILO
MATTYGILO approved these changes Jan 8, 2021
View reviewed changes
Copy link

@MATTYGILO MATTYGILO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please approve this

luanpotter
luanpotter approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luanpotter luanpotter merged commit 62b0d94 into bluefireteam:master Jan 8, 2021
@koji-1009
Copy link
Contributor Author

Thanks!

@koji-1009 koji-1009 deleted the add_kotlin_gradle_plugin branch January 8, 2021 14:51
@koji-1009 koji-1009 mentioned this pull request Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@luanpotter luanpotter luanpotter approved these changes

@kivancg kivancg kivancg approved these changes

@MATTYGILO MATTYGILO MATTYGILO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

urred evaluating project ':audioplayers'. > Plugin with id 'kotlin-android' not found. *
5 participants
@koji-1009 @erickzanardo @luanpotter @kivancg @MATTYGILO