Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ways to rebalance ordered sets #10

Merged
merged 4 commits into from Mar 13, 2021
Merged

Add ways to rebalance ordered sets #10

merged 4 commits into from Mar 13, 2021

Conversation

luanpotter
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 6, 2021

Pull Request Test Coverage Report for Build 649432238

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 94.545%

Totals Coverage Status
Change from base Build 647893809: 1.5%
Covered Lines: 52
Relevant Lines: 55

💛 - Coveralls

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just changelog entry missing

/// If the priority function changed for certain known elements but not all,
/// you can use this instead of [rebalanceAll].
/// In general be careful with using comparing functions that can change.
/// Note: rebalancing is **not** stable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by not been stable? What could happen? Maybe elaborate more on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luanpotter luanpotter merged commit 152e420 into master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants