Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queryable Ordered Set #11

Merged
merged 4 commits into from May 27, 2021
Merged

Queryable Ordered Set #11

merged 4 commits into from May 27, 2021

Conversation

luanpotter
Copy link
Member

This is one more thing I extracted from Tales (with some improvements). Queryable Ordered Sets allow you to register queries (pre-defined types) that are then cached as sub-lists and can be queried at O(0), at the expense of extra indexing upon add.

This is extremely valuable because on most complex games you need to iterate subsets of the component list every tick, but rarely you add new components.

@coveralls
Copy link

coveralls commented May 24, 2021

Pull Request Test Coverage Report for Build 872841923

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 96.154%

Totals Coverage Status
Change from base Build 652245115: 1.6%
Covered Lines: 75
Relevant Lines: 78

💛 - Coveralls

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were very pedagogical and easy to understand, lgtm!

@luanpotter luanpotter merged commit 913e5fd into master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants