Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No-op operation on multiple register for the same type #12

Merged
merged 5 commits into from Aug 22, 2021
Merged

No-op operation on multiple register for the same type #12

merged 5 commits into from Aug 22, 2021

Conversation

spydon
Copy link
Member

@spydon spydon commented Aug 9, 2021

No description provided.

@spydon spydon requested a review from luanpotter August 9, 2021 21:49
luanpotter
luanpotter approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w one comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1156064532

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.25%
Totals Coverage Status
Change from base Build 888130600: 0.1%
Covered Lines: 77
Relevant Lines: 80
💛 - Coveralls

@luanpotter luanpotter merged commit 0734ea2 into bluefireteam:master Aug 22, 2021
@spydon spydon deleted the spydon.register-no-op branch August 22, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spydon @coveralls @luanpotter