Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please help to add CI support for riscv64 #284

Closed
Hamlin-Li opened this issue Oct 24, 2023 · 3 comments
Closed

Please help to add CI support for riscv64 #284

Hamlin-Li opened this issue Oct 24, 2023 · 3 comments

Comments

@Hamlin-Li
Copy link

Hi,
Currently riscv64 is supported by zstd-jni pr #282 .

It's tested locally, but not regularly on github. I tried to modify the ci script to enable the CI support for riscv64, but seems I don't have the right to do so.
Can someone help to do it?

Thanks!

(Seems it's simple to enable it? I'm not sure, I did not modify this script before.)

diff --git a/.github/workflows/ci-qemu-cross.yml b/.github/workflows/ci-qemu-cross.yml
index e8df8fa..7c962f2 100644
--- a/.github/workflows/ci-qemu-cross.yml
+++ b/.github/workflows/ci-qemu-cross.yml
@@ -5,7 +5,8 @@ jobs:
         strategy:
             matrix:
                 include: [
-                    { platform: s390x }
+                    { platform: s390x },
+                    { platform: riscv64 },
                 ]
         runs-on: ubuntu-latest
         steps:
@luben
Copy link
Owner

luben commented Oct 26, 2023

I am not sure it's going to be so easy. I will try it

@Hamlin-Li
Copy link
Author

Thanks Luben.
Seem it's because when I generated my github access token, I did include the workflow.
I can also try it later.

@Hamlin-Li
Copy link
Author

I have created the #285.
( The reason I could not create the pr is because of wrong access token, sorry for the inconvenience. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants