Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask question if return is NONE #1

Open
jvfe opened this issue Apr 22, 2022 · 0 comments
Open

Don't ask question if return is NONE #1

jvfe opened this issue Apr 22, 2022 · 0 comments

Comments

@jvfe
Copy link
Contributor

jvfe commented Apr 22, 2022

  • Wikidata Curation Tools version: 0.0.1
  • Python version: 3.10
  • Operating System: Manjaro Linux

Description

When the wikidata API lookup returns an object with NONE as values, it still asks the question:

Is the QID for 'Bachelor's Degree in Genetics'  
 NONE - NONE (NONE) ? (y/n)

This doesn't make sense. It should instead jump directly to:

What is the QID for: 'Bachelor's Degree in Genetics' ?

Maybe make the wikidata lookup return an error if the JSON received from the API is empty and make add_key handle that error with a try/except -> If error is received ask "what is the qid".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant