Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2] Recipe lookup on interact taking a long time #1

Open
PapiOphidian opened this issue Oct 20, 2022 · 1 comment
Open

[1.19.2] Recipe lookup on interact taking a long time #1

PapiOphidian opened this issue Oct 20, 2022 · 1 comment

Comments

@PapiOphidian
Copy link

The modpack I've made does include quite a few mods which adds a lot of recipes and the time taken to build a list of craftable recipes is very considerable. The time wasted is also very noticeable considering the fact that this happens every time you interact with the bench versus what can be crafted being cached.

What I would suggest is to not just take a standard approach and caching when at least one of the inventories the bench searches through changes, but rather on recipes loading (startup, runtime through stuff like kubejs or the likes), building a tree of everything and using an algorithm like alpha-beta pruning to filter the list whenever an inventory the bench searches through does eventually change and cache that result.

If that suggestion isn't viable, then I'd at least let the user know that the bench is looking through the recipes somehow and possibly as the bench finds recipes, populate the list of craftables versus waiting for the entire filter to finish.

@leafreynolds
Copy link

+1 to this issue. If the recipe finder takes too long, it just silently dies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants