Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 2 Peer Review - Simone Giambrone s317002 #2

Open
JustLooller opened this issue Nov 23, 2023 · 0 comments
Open

Lab 2 Peer Review - Simone Giambrone s317002 #2

JustLooller opened this issue Nov 23, 2023 · 0 comments
Assignees
Labels
Lab 2 Lab 2 Peer Review Peer Review

Comments

@JustLooller
Copy link

Hi! After going through your code this is what I noticed:

  • First of all, the lab request was to implement an Evolution Strategy, such as (1+$\lambda$) or (1,$\lambda$), not an Evolutionary Algorithm, but anyway, the code is very well written and full of comments and explanations on what you're doing and how you're doing it, so props for that.
  • The implementation of the mutation() and crossover() functions is really nice, especially weighting the fitness of the parents before crossing over.
  • I would've personally increased the number of games per generation and generations, since changes in Evolutionary Algorithms tend to be slow to appear.

Overall good job on the lab, good luck for the next ones!

@lucabubi lucabubi self-assigned this Nov 24, 2023
@lucabubi lucabubi added Peer Review Peer Review Lab 2 Lab 2 labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lab 2 Lab 2 Peer Review Peer Review
Projects
None yet
Development

No branches or pull requests

2 participants