Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw FRAME_ENCODING_ERRORs when MAX_STREAMs and STREAMS_BLOCKED frame exceed the maximum stream count #2209

Merged
merged 3 commits into from Nov 9, 2019

Conversation

marten-seemann
Copy link
Member

As outlined in quicwg/base-drafts#3042, we can throw an error as early as possible.

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #2209 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
+ Coverage   86.37%   86.37%   +<.01%     
==========================================
  Files         106      106              
  Lines        7666     7668       +2     
==========================================
+ Hits         6621     6623       +2     
  Misses        782      782              
  Partials      263      263
Impacted Files Coverage Δ
streams_map.go 93.13% <ø> (-0.1%) ⬇️
internal/wire/streams_blocked_frame.go 100% <100%> (ø) ⬆️
internal/wire/max_streams_frame.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914193c...5d54a11. Read the comment docs.

@marten-seemann marten-seemann merged commit 2c2b5da into master Nov 9, 2019
@marten-seemann marten-seemann deleted the stream-count-errors branch November 9, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants