Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop the timer when the session's run loop returns #2516

Merged
merged 2 commits into from May 2, 2020
Merged

Conversation

marten-seemann
Copy link
Member

Fixes #2515.

@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #2516 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2516   +/-   ##
=======================================
  Coverage   86.13%   86.14%           
=======================================
  Files         122      122           
  Lines        9533     9536    +3     
=======================================
+ Hits         8211     8214    +3     
  Misses        984      984           
  Partials      338      338           
Impacted Files Coverage Δ
internal/utils/timer.go 100.00% <100.00%> (ø)
session.go 75.34% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d66eac...286dcf5. Read the comment docs.

@marten-seemann marten-seemann merged commit c0b6d4e into master May 2, 2020
@marten-seemann marten-seemann deleted the stop-timer branch May 6, 2020 01:18
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop the timer when the session is closed
3 participants