Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the ChaCha20 interop test case #2517

Merged
merged 1 commit into from May 6, 2020

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #2517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2517   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files         122      122           
  Lines        9533     9533           
=======================================
  Hits         8211     8211           
  Misses        984      984           
  Partials      338      338           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d66eac...9c501a0. Read the comment docs.

@rogers0
Copy link

rogers0 commented May 5, 2020

@marten-seemann thanks for the patch!

I'm trying to packaging this project into Debian.
I also meet this issue, but after your patch, it seems still fails.

  using TLS_CHACHA20_POLY1305_SHA256
  /build/golang-github-lucas-clemente-quic-go-0.15.6/obj-x86_64-linux-gnu/src/github.com/lucas-clemente/quic-go/internal/handshak
e/aead_test.go:20
    header encryption
    /build/golang-github-lucas-clemente-quic-go-0.15.6/obj-x86_64-linux-gnu/src/github.com/lucas-clemente/quic-go/internal/handsh
ake/aead_test.go:62
      encrypts and encrypts the header, for a 0xfff..fff sample [It]
      /build/golang-github-lucas-clemente-quic-go-0.15.6/obj-x86_64-linux-gnu/src/github.com/lucas-clemente/quic-go/internal/hand
shake/aead_test.go:83

      Test Panicked
      chacha20: counter overflow
      /build/golang-github-lucas-clemente-quic-go-0.15.6/obj-x86_64-linux-gnu/src/golang.org/x/crypto/chacha20/chacha_generic.go:
206

@marten-seemann
Copy link
Member Author

@rogers0 This is unrelated to this PR. It should have been fixed by #2508, can you please make sure your dependencies are up to date? Especially golang.org/x/crypto. If the problem then still exists, please open a new issue.

@rogers0
Copy link

rogers0 commented May 5, 2020

@marten-seemann Thanks for your information!
Yes, all tests get passed after upgrading golang.org/x/crypto

@marten-seemann marten-seemann merged commit 6bcb4e6 into master May 6, 2020
@marten-seemann marten-seemann deleted the chacha-interop-test branch May 6, 2020 01:06
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants