bundle small writes on streams #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
+ Coverage 86.12% 86.16% +0.03%
==========================================
Files 122 122
Lines 9542 9550 +8
==========================================
+ Hits 8218 8228 +10
+ Misses 985 984 -1
+ Partials 339 338 -1
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2523.
Evaluated by having a for-loop do 100 20-byte writes on a stream and counting the number of packets. Before this PR, we'd send 100 packets containing STREAM frames. With this PR, this number is down to 5 packets. This is not ideal (2000 bytes could be sent in just 2 packets), but it's a massive improvement nevertheless.