Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split PTO calculation into a separate function #2576

Merged
merged 4 commits into from Jun 3, 2020

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 28, 2020

See quicwg/base-drafts#3681. Also fixes #2518.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #2576 into master will increase coverage by 0.00%.
The diff coverage is 80.70%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2576   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         122      122           
  Lines        9744     9761   +17     
=======================================
+ Hits         8407     8422   +15     
- Misses        996      997    +1     
- Partials      341      342    +1     
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 73.74% <80.70%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e5bb5...dda9c27. Read the comment docs.

@marten-seemann marten-seemann merged commit b9f26ac into master Jun 3, 2020
@marten-seemann marten-seemann deleted the split-pto-calculation branch June 4, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't arm PTO timer until the handshake is complete
3 participants