Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ACK decimation #2599

Merged
merged 2 commits into from Jul 28, 2020
Merged

remove ACK decimation #2599

merged 2 commits into from Jul 28, 2020

Conversation

marten-seemann
Copy link
Member

The benefits of this are unclear when using Reno / Cubic.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #2599 into master will increase coverage by 0.04%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
+ Coverage   86.74%   86.79%   +0.04%     
==========================================
  Files         124      124              
  Lines        9905     9892      -13     
==========================================
- Hits         8592     8585       -7     
+ Misses        980      977       -3     
+ Partials      333      330       -3     
Impacted Files Coverage Δ
internal/ackhandler/received_packet_handler.go 76.06% <ø> (ø)
internal/ackhandler/received_packet_tracker.go 85.19% <73.68%> (+4.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a854a4a...6b7f204. Read the comment docs.

@marten-seemann marten-seemann merged commit b5e6534 into master Jul 28, 2020
@marten-seemann marten-seemann deleted the remove-ack-decimation branch July 28, 2020 03:17
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants