Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only arm the application data PTO timer after the handshake is confirmed #2689

Merged

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jul 27, 2020

Fixes #2688.

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #2689 into master will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   86.74%   86.73%   -0.01%     
==========================================
  Files         124      124              
  Lines        9905     9905              
==========================================
- Hits         8592     8591       -1     
- Misses        980      981       +1     
  Partials      333      333              
Impacted Files Coverage Δ
session.go 77.35% <0.00%> (-0.10%) ⬇️
internal/ackhandler/sent_packet_handler.go 73.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a854a4a...8db76ab. Read the comment docs.

@marten-seemann marten-seemann merged commit 03a1db6 into master Jul 29, 2020
@marten-seemann marten-seemann deleted the dont-arm-app-data-pto-before-handshake-confirmed branch July 29, 2020 01:55
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't arm the 1-RTT PTO timer before the handshake is confirmed
2 participants