don't retransmit PING frames added to ACK-only packets #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every 20 non-ack-eliciting packets, we add a PING frame to make that packet ack-eliciting. That way, we regularly receive acknowledgements, even if we're not actually sending any data. This allows us to clean up our sent packet history. There's no need to retransmit this PING frame though. We'll just send a new one if one of them is lost, as soon as we've sent another 20 non-ack-eliciting packets.
Codecov Report
@@ Coverage Diff @@
## master #2942 +/- ##
==========================================
- Coverage 86.04% 86.03% -0.01%
==========================================
Files 134 134
Lines 9286 9286
==========================================
- Hits 7990 7989 -1
Misses 938 938
- Partials 358 359 +1
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every 20 non-ack-eliciting packets, we add a PING frame to make that packet ack-eliciting. That way, we regularly receive acknowledgements, even if we're not actually sending any data. This allows us to clean up our sent packet history.
There's no need to retransmit this PING frame though. We'll just send a new one if one of them is lost, as soon as we've sent another 20 non-ack-eliciting packets.