Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to strictly prioritize streams, defaulting to round-robin #3442

Closed
wants to merge 3 commits into from

Conversation

kixelated
Copy link
Contributor

Only applies when the congestion window is full. This gives applications a way to specify which streams should be sent first under poor network conditions.

Luke Curley added 3 commits June 2, 2022 15:30
This is inefficient with a large number of active streams but I don't
care enough to refactor.
@kixelated
Copy link
Contributor Author

I didn't actually meant to submit a PR upstream; just to my fork. Oh well.

Priority could be replaced with Order or Precedence, seeing as it's an often overloaded term. There's a sort that could be removed with a bit of a refactoring but I suppose it doesn't matter.

@marten-seemann
Copy link
Member

Only applies when the congestion window is full.

Why?

@kixelated
Copy link
Contributor Author

Only applies when the congestion window is full.

Why?

Or when rate limited by a pacer.

I'm currently working on sample code for a new live video protocol. The idea is that we prioritize newer media during congestion, skipping over old media instead of buffering. This either requires cancelling streams when we're network bound or more elegantly, prioritizing streams. The lowest priority streams will be starved until the network recovers or they are cancelled.

This code review adds the ability to specify which streams take strict priority instead of using round-robin. A future implementation might use weights instead.

@marten-seemann
Copy link
Member

For video you probably want to do a lot more than just use a different prioritisation scheme. fyi, there's a MoQ (Media over QUIC) working group at the IETF now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants