factorize code

mobula9 · Apr 10, 2016 · 0b23618 · 0b23618
1 parent eb5db0f
commit 0b23618
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 26 deletions.
diff --git a/Processor/LclProcessor.php b/Processor/LclProcessor.php
@@ -32,22 +32,14 @@ public function format(ArrayCollection $data)
             $date = new \DateTime();
             $date->setDate(2000 + (int) substr($dateRaw, 6, 2), (int) substr($dateRaw, 3, 2), (int) substr($dateRaw, 0, 2));
             $date->setTime(12, 0, 0);
-            // Value
-            $debitRaw = $item[3];
-            if (strlen($debitRaw)) {
-                $value = abs((float) str_replace(',', '.', str_replace(' ', '', $debitRaw)));
-                $debit = true;
-            } else {
-                $creditRaw = $item[4];
-                $value = (float) str_replace(',', '.', str_replace(' ', '', $creditRaw));
-                $debit = false;
-            }
+            // Transaction
+            $transaction = $this->frenchTransactionFormatter($item[3], $item[4]);
 
             return [
-                'date' => $date,
+                'date'  => $date,
                 'label' => $item[1],
-                'value' => $value,
-                'debit' => $debit,
+                'value' => $transaction['value'],
+                'debit' => $transaction['debit'],
             ];
         });
 

diff --git a/Processor/Processor.php b/Processor/Processor.php
@@ -25,7 +25,24 @@ public function __toString()
         return (string) $this->configuration['name'];
     }
 
-    public function frenchDateFormatter($raw)
+    /**
+     * @param string $debitRaw
+     * @param string $creditRaw
+     *
+     * @return array
+     */
+    public function frenchTransactionFormatter($debitRaw, $creditRaw)
     {
+        if (strlen($debitRaw)) {
+            $value = abs((float) str_replace(',', '.', str_replace(' ', '', $debitRaw)));
+            $debit = true;
+        } else {
+            $value = (float) str_replace(',', '.', str_replace(' ', '', $creditRaw));
+            $debit = false;
+        }
+        return [
+            'value' => $value,
+            'debit' => $debit,
+        ];
     }
 }
diff --git a/Processor/SgProProcessor.php b/Processor/SgProProcessor.php
@@ -41,23 +41,15 @@ public function format(ArrayCollection $data)
             $valueDate->setDate((int) substr($dateRaw, 6, 4), (int) substr($dateRaw, 3, 2), (int) substr($dateRaw, 0, 2));
             $valueDate->setTime(12, 0, 0);
 
-            // Value
-            $debitRaw = $item[3];
-            if (strlen($debitRaw)) {
-                $value = abs((float) str_replace(',', '.', str_replace('.', '', $debitRaw)));
-                $debit = true;
-            } else {
-                $creditRaw = $item[4];
-                $value = (float) str_replace(',', '.', str_replace('.', '', $creditRaw));
-                $debit = false;
-            }
+            // Transaction
+            $transaction = $this->frenchTransactionFormatter($item[3], $item[4]);
 
             return [
                 'date' => $date,
                 'value_date' => $valueDate,
                 'label' => $item[2],
-                'value' => $value,
-                'debit' => $debit,
+                'value' => $transaction['value'],
+                'debit' => $transaction['debit'],
             ];
         });