Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a GIF for each sorting algorithm #45

Closed
LucasPilla opened this issue Oct 19, 2020 · 10 comments · Fixed by #80
Closed

Make a GIF for each sorting algorithm #45

LucasPilla opened this issue Oct 19, 2020 · 10 comments · Fixed by #80
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@LucasPilla
Copy link
Owner

LucasPilla commented Oct 19, 2020

The idea is basically record a gif for all sorting algorithms, with the same delay and size, to replace the GIFS from github wiki page

@LucasPilla LucasPilla added documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Oct 19, 2020
@LucasPilla LucasPilla added this to the Project finals and release milestone Oct 19, 2020
@asinghgaba
Copy link
Contributor

Hey! This looks a fairly easy task and I think I can do it. Let me know if you want me to work on it, I'll be happy to do it.

@LucasPilla
Copy link
Owner Author

Sure!

@asinghgaba
Copy link
Contributor

@LucasPilla I've done the changes but can't figure it how to open a pull request for the wiki. The link for my repo is HERE

@LucasPilla
Copy link
Owner Author

Unfortunately there is no way to open a pr for the wiki page!
@asinghgaba I'm so sorry, I thought i had specified the size and I forgot to insert an exemple.
I would chose a size of 200 and the gif should contain just the bars, example:
mergesort
I appreciate what you did, it must have taken you some time to record those gifs. I would be so thankful if you remake it.
Anyway, i will manage some way to insert you as a contributor.

@asinghgaba
Copy link
Contributor

Okay no problem I’ll do that by tonight and let you know once it’s done.

@asinghgaba
Copy link
Contributor

UPDATE @LucasPilla the changes are done, tbh it looks much cleaner now.

@LucasPilla
Copy link
Owner Author

@asinghgaba Wow, it looks incredible!
Can I use your repository as a ofical way to contribute in wiki page? So if anyone wants to contribute they will commit to your repo.

@asinghgaba
Copy link
Contributor

Thank you @LucasPilla
Yh no problem at all.

@LucasPilla
Copy link
Owner Author

@asinghgaba Can you open a pull request to my repo adding a folder with all gifs?

@asinghgaba
Copy link
Contributor

Okay, I'll do it now.

@LucasPilla LucasPilla linked a pull request Feb 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants