Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Removing android.widget.Adapter dependency from ItemLoader #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Removing android.widget.Adapter dependency from ItemLoader #26

wants to merge 4 commits into from

Conversation

mr-archano
Copy link

Using generics in the ItemLoader is possible to avoid the dependency from android.widget.Adapter and ease future generalisations that can use other type of adapters/target views (eg: RecyclerView).
This has been possible because ItemLoader does not rely on any android.widget.Adapter behaviour, but uses that type only in the signature of some of its business methods.

@mr-archano mr-archano changed the title Removing adapter dependency from ItemLoader Removing android.widget.Adapter dependency from ItemLoader Sep 21, 2014
@lucasr
Copy link
Owner

lucasr commented Sep 23, 2014

Thanks @mr-archano! This is looking good after quick skim. I'll do more thorough review later today or tomorrow.

@mr-archano
Copy link
Author

I have worked on a quick&dirty port of Smoothie that is working with the RecyclerView (mostly a copy/paste of the ItemManager and ItemManaged classes), but the change in this PR was needed in order to preserve the Smoothie API (the user only knows about ItemLoader). It would be cool to hear from you about the Smoothie 1.0 API, I would be happy to contribute :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants