Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability? #19

Closed
hrj opened this issue Apr 5, 2021 · 4 comments
Closed

Stability? #19

hrj opened this issue Apr 5, 2021 · 4 comments

Comments

@hrj
Copy link

hrj commented Apr 5, 2021

Hi,

In the Readme, you clearly mention that Fibry is still a WIP, but still, would like to know how stable it really is?

We are trying out Fibry and seeing some issues when we run tests with 1500+ concurrent users, using https://locust.io/
(On normal JDK, no Loom).

We are still debugging the issues, which could be in on our code FWIW, but wanted to check with you in parallel.

Perhaps it might be a good idea to run load tests in CI. We did it recently for our project, so if you are interested, I could submit a PR for that.

cheers,
HRJ

@lucav76
Copy link
Owner

lucav76 commented Apr 26, 2021

Hi,
Sorry for having waited so much to answer, I did not notice before.
Fibry is still experimental, in the sense that I am waiting for Loom to be merged into the mainline, plus there might be some corner cases that are not covered, but it should be stable.
I use it in production, though not with many actors, but it should not change much.

If you have more details on the problematic test, I would be happy ot check it.
If you are using it for HTTP, I hope that you are not using the Java embedded HTTP server, as that's only meant as a demo or for something really simple.

@lucav76
Copy link
Owner

lucav76 commented Apr 26, 2021

The support as distributed actor system is more experimental, and I would expect issues when there are network problems, so please let me know how you use it. If you have a PR or if you can share some code, that might also help.

@hrj
Copy link
Author

hrj commented Apr 26, 2021

Hi,

Yes, we were using the embedded HTTP server. Our needs are very simple, with just a few endpoints. But we wanted to choose something that could scale up later. So we thought Fibry's embedded server might be a good choice.

But it was giving very unpredictable performance, under stress, even on the regular JVM. About 10% of the HTTP requests (for a simple endpoint that returns a static string) were stuck for more than 15 seconds.

While we were waiting for your reply (no pun intended), I created a simple HTTP server wrapped around the com.sun...HttpServer. I tested it with loom using an executor that creates a virtual threads and it gives pretty good performance.

So we went with that implementation.

But anyway, thanks for your response. Will keep an eye on updates from this project.

@hrj hrj closed this as completed Apr 26, 2021
@lucav76
Copy link
Owner

lucav76 commented Apr 27, 2021

Cool! I am happy to hear that you solved your problem. I will check if I can do something about Fibry.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants