Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cookie SameSite "none" not available as an option #1320

Closed
dmaksimov opened this issue Dec 28, 2023 · 3 comments · Fixed by #1359
Closed

[Bug]: Cookie SameSite "none" not available as an option #1320

dmaksimov opened this issue Dec 28, 2023 · 3 comments · Fixed by #1359
Labels
feature request New feature requests

Comments

@dmaksimov
Copy link

Package

lucia-auth

Describe the bug

The sameSite attribute for cookies allows "lax" and "strict" but is missing "none".

sameSite?: "strict" | "lax";

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value

Is there a reason for this?

I can create a PR to add it but wanted to check first.

@dmaksimov dmaksimov added the bug Something ain't right... label Dec 28, 2023
@pilcrowOnPaper
Copy link
Member

Third party cookies are being deprecated by browsers, so I don’t see a reason to support it

@dmaksimov
Copy link
Author

Ah gotcha, that makes sense.

Any suggestions on displaying authenticated content inside an iframe on a different domain securely?

@pilcrowOnPaper
Copy link
Member

Makes sense. Yeah if you could make a PR for it, I can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants