Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor styling issues on the webpage. #122

Closed
Andreto opened this issue Nov 1, 2020 · 2 comments
Closed

Minor styling issues on the webpage. #122

Andreto opened this issue Nov 1, 2020 · 2 comments
Labels
🌍 site Has to do something with the Lucide website

Comments

@Andreto
Copy link
Member

Andreto commented Nov 1, 2020

1. Search input border-radius on dark mode.

Issue
The input field has a border-radius but the chakra-input__group css-r27y85 element is poking out underneath. On light mode this is not an issue since the color of the element is the same as the body.
image

Solution
Give the chakra-input__group css-r27y85 element the same border-radius as the input.
or
Give the chakra-input__group css-r27y85 element the same background-color as the body. (Maybe this messes up the color of the input.)

2. Color input box.

Issue
The color input elements have a border-radius on the bottom with no padding to the box below.
image

Solution
Maybe put no border-radius on the bottom corners. I also think that the color field could have a border around it. Looks a lot better on the bright side.
image

Alternatively, some margin between the input and color field.
image

@ericfennis
Copy link
Member

@Andreto (1) Wow didn't saw that, really sharp 😄
(2) Good point, I think the color picker can improved, I noticed it's really laggy if you drag the color picker and heu slider as wel, I think it fires too much events. @aelfric Do you have time to take a look to it?

@aelfric
Copy link
Contributor

aelfric commented Nov 1, 2020

Yes. I can take a look.

@ericfennis ericfennis added the 🌍 site Has to do something with the Lucide website label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌍 site Has to do something with the Lucide website
Projects
None yet
Development

No branches or pull requests

3 participants