Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: duplicate-react #137

Closed
schwamic opened this issue Nov 16, 2020 · 4 comments
Closed

error: duplicate-react #137

schwamic opened this issue Nov 16, 2020 · 4 comments
Labels
🐛 bug Something isn't working

Comments

@schwamic
Copy link

schwamic commented Nov 16, 2020 •
edited

I use yarn workspaces, and as I moved lucide-react to the root package.json, I got an error: duplicate-react. At the moment I fixed the problem via yarn resolutions, to make sure to install only one react version. I think, react a well as prop-types should be peer-deps.

lucide-react@0.1.2-beta.3
@schwamic schwamic changed the title react should be a peer-dependency error: duplicate-react Nov 16, 2020
@ericfennis
Copy link
Member

@schwamic Thank you for creating this issue, I will look in to it!

@ericfennis ericfennis added the 🐛 bug Something isn't working label Nov 17, 2020
@ericfennis
Copy link
Member

@schwamic I added react and prop-types as peer deps, I released it on lucide-react@0.1.2-beta.5
I'm curious you still experience this issue, let me know.

@schwamic
Copy link
Author

@ericfennis thank you for the improvements! Now works without yarn resolutions.

@ericfennis
Copy link
Member

@schwamic great to hear that, thanks for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericfennis @schwamic