Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icon request] Panda concept (+ some questions) #1880

Open
5 tasks done
smnandre opened this issue Feb 11, 2024 · 23 comments
Open
5 tasks done

[icon request] Panda concept (+ some questions) #1880

smnandre opened this issue Feb 11, 2024 · 23 comments

Comments

@smnandre
Copy link
Contributor

smnandre commented Feb 11, 2024

Icon name

panda

Use cases

  • I need some little animals icons for a kid-targetted project, and pandas are a really common choice for such icons/animals.
  • Indicator for maps that there is a zoo here (thx @jguddas )
    But mostly, because panda are cools.

Design ideas

I started something, I'd love to get any advice / feedback / guidance :)

And i have two questions:

  • Is there any smart way to make the ears "filled" ?
  • Same thing for the shape behind the eyes ? (that currently will reveal some blank if stroke-width = 1)
Capture d’écran 2024-02-11 à 17 47 51 Capture d’écran 2024-02-11 à 17 47 39

I took inspiration / tried to keep coherence with the two other animal face icons

Capture d’écran 2024-02-11 à 17 47 11

Checklist

  • I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
  • I have searched existing icons to make sure it does not already exist and I didn't find any.
  • I am not requesting a brand logo and the art is not protected by copyright.
  • I am not requesting an icon that includes religious, political imagery or hate symbols.
  • I have provided appropriate use cases for the icon(s) requested.
@jguddas
Copy link
Member

jguddas commented Feb 11, 2024

Another use case: Indicator for maps that there is a zoo here.

@jguddas
Copy link
Member

jguddas commented Feb 11, 2024

The eye shape violates the 2px gap rule, how does it look with just circles for eyes?

@smnandre
Copy link
Contributor Author

Capture d’écran 2024-02-11 à 18 34 29 Capture d’écran 2024-02-11 à 18 34 02 Capture d’écran 2024-02-11 à 18 33 35

No perfect solution there :(

@chessurisme
Copy link
Contributor

chessurisme commented Feb 12, 2024

What if the eye looks like this (add some dots):
image

@karsa-mistmere
Copy link
Member

What if the eye looks like this (add some dots): image

Can you post a 100% view of this? (a 24 by 24 raster image)

@chessurisme
Copy link
Contributor

I am just focusing on eyes, btw, disregard the shape of the head and the ears, it is violating, I know:
image

@karsa-mistmere
Copy link
Member

(a 24 by 24 raster image)

@chessurisme: I really do mean a literal 24 by 24 pixel image, so that we can review how the icon will look on low DPI screens. :)

@chessurisme
Copy link
Contributor

(a 24 by 24 raster image)

@chessurisme: I really do mean a literal 24 by 24 pixel image, so that we can review how the icon will look on low DPI screens. :)

Thanks for the patience, @karsa-mistmere. Give me time.

@chessurisme
Copy link
Contributor

panda

@karsa-mistmere
Copy link
Member

Yeah, unfortunately the center of the eyes is barely visible at 100%. 🫤

@chessurisme
Copy link
Contributor

What if we get rid on that eyes?

@chessurisme
Copy link
Contributor

chessurisme commented Feb 13, 2024

Take a look:
panda

@smnandre
Copy link
Contributor Author

I used your suggestions / feedbacks and the tests from chessurisme, and ... i'm quite happy with how it looks

Panda-24
Panda-48
Panda-96

WDYT ?

@chessurisme
Copy link
Contributor

Let @karsa-mistmere decide, pretty decent for me, but still thinking about the eyes.

@karsa-mistmere
Copy link
Member

I used your suggestions / feedbacks and the tests from chessurisme, and ... i'm quite happy with how it looks

Panda-24 Panda-48 Panda-96

WDYT ?

Neither the eyes, nor the ears are are to our guidelines, I'm afraid, there should be a 2px gap between the lines.

@smnandre
Copy link
Contributor Author

I'm walking on eggshells here... no offense intended!! ☮️

I've noticed that some icons seem to have "similar" features to this panda (not a panda matter, I'm just trying to fully understand... so as not to waste your time with future submissions :) ).

Capture d’écran 2024-02-15 à 14 35 11

I imagine there are thousands of reasons for exceptions, or the weight of seniority, etc... or maybe i did not understood one rule (very possible 😅 )

Is the idea to have "strict" rules (at least aiming for maximum application), or are they more like "recommendations," and you evaluate on a case-by-case basis?

@jguddas
Copy link
Member

jguddas commented Feb 15, 2024

We try to enforce them strictly.

And yes some icons are not 100% great, citrus looks pretty okay tho when it comes to the 2px rule.

@karsa-mistmere
Copy link
Member

@smnandre: I'm using a crudely reproduced version of your panda icon for demonstration purposes, and something from my drafts as a comparison to illustrate why we have this guideline:
image
(I'm also taking the liberty to use tractor as already fixed by @jguddas in #1894, that .5px circle radius is just a rendering bug).

In all other cases, the separation between elements remains even at 3px (even if their appearance is admittedly less than ideal). What I think is probably the easiest way to understand this rule: can you fit a circle with a radius of 1px between the elements / inside the gap? If so, you're in the clear, if not, it might not be the end of the world (we do have a few offenders), but we do usually try everything in our power to make things work:
image

(fish and hop for example should probably be fixed)

@smnandre
Copy link
Contributor Author

@jguddas @karsa-mistmere thank you very much for this patient and detailed explanation !

I've always set lucide with a 1.5 stroke.. so i'm used to see more "space" than in the default render, avoiding some of the problematics i guess.

PS: @karsa-mistmere my face, your ears, just need to find something to ease the eyes and we'll have a great panda :)

@karsa-mistmere karsa-mistmere mentioned this issue Feb 15, 2024
3 tasks
@smnandre
Copy link
Contributor Author

Oh i love it !

I'd maybe shorten just a tiny bit the "eyes", but 👏

@chessurisme
Copy link
Contributor

Oh i love it !

I'd maybe shorten just a tiny bit the "eyes", but 👏

Show us what you got.. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants