Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of certain icons is not coherent with the name on the website #1996

Closed
6 of 27 tasks
cluk3 opened this issue Mar 18, 2024 · 8 comments
Closed
6 of 27 tasks

Naming of certain icons is not coherent with the name on the website #1996

cluk3 opened this issue Mar 18, 2024 · 8 comments
Labels
🐛 bug Something isn't working

Comments

@cluk3
Copy link

cluk3 commented Mar 18, 2024

Package

  • lucide
  • lucide-angular
  • lucide-flutter
  • lucide-preact
  • lucide-react
  • lucide-react-native
  • lucide-solid
  • lucide-svelte
  • lucide-vue
  • lucide-vue-next
  • Figma plugin
  • source/main
  • other/not relevant

Version

0.344.0

Can you reproduce this in the latest version?

  • Yes
  • No

Browser

  • Chrome/Chromium
  • Firefox
  • Safari
  • Edge
  • iOS Safari
  • Opera
  • Other/not relevant

Operating system

  • Windows
  • Linux
  • macOS
  • Other/not relevant

Description

When I look for a icon I need I go on the website search and when I find the icon name I expect the export to have same name the icon has on the website only CamelCased instead of kebab-cased. This works most of the times but sometimes it doesn't.
One example is the Ellipsis icon which is exported within its alias More. On the website I couldn't find any reference of the alias, so I had to find it out myself by going in the node module and open the json file.
I would expect the Icon to be exported with the name of the file AND with the name of the alias, or at least for the alias to be referenced on the website

Steps to reproduce

Try to import Ellipsis icon

Checklist

  • I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
@cluk3 cluk3 added the 🐛 bug Something isn't working label Mar 18, 2024
@jguddas
Copy link
Member

jguddas commented Mar 18, 2024

import { Ellipsis } from 'lucide-react' works just fine.

@jguddas jguddas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@karsa-mistmere
Copy link
Member

Please upgrade to the latest package.

@ajzbc
Copy link

ajzbc commented Apr 6, 2024

Running into the same problem with lucide-svelte not exporting Ellipsis

Using 0.365.0

@karsa-mistmere
Copy link
Member

Running into the same problem with lucide-svelte not exporting Ellipsis

Using 0.365.0

I can definitely see it exported and can import it. Can you check if removing node_modules and reinstalling works?
image

@justuskilianwolff
Copy link

justuskilianwolff commented Apr 7, 2024

@karsa-mistmere I deleted my node_modulesdir and ran npm install, npm updatebut still can't find ellipsis. That line you highlighted is not found in my aliases.d.ts. I am running

"node_modules/lucide-svelte": {
			"version": "0.316.0",
			"resolved": "https://registry.npmjs.org/lucide-svelte/-/lucide-svelte-0.316.0.tgz",
			"integrity": "sha512-6mtBw/aU1IIVXfN6AXLSwsbeCFX/2/tTy84rrDTDsOq7BEijFbvObQsPEWPxJ0EyCjUXOYfAvfkZzMosYjyGqA==",
			"peerDependencies": {
				"svelte": ">=3 <5"
			}
		},

Also the paths look different in my version?
Screenshot 2024-04-07 at 13 05 54

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Apr 7, 2024

@karsa-mistmere I deleted my node_modulesdir and ran npm install, npm updatebut still can't find ellipsis. That line you highlighted is not found in my aliases.d.ts. I am running

"node_modules/lucide-svelte": {
			"version": "0.316.0",
			"resolved": "https://registry.npmjs.org/lucide-svelte/-/lucide-svelte-0.316.0.tgz",
			"integrity": "sha512-6mtBw/aU1IIVXfN6AXLSwsbeCFX/2/tTy84rrDTDsOq7BEijFbvObQsPEWPxJ0EyCjUXOYfAvfkZzMosYjyGqA==",
			"peerDependencies": {
				"svelte": ">=3 <5"
			}
		},

Also the paths look different in my version? Screenshot 2024-04-07 at 13 05 54

Please upgrade, you're like 50 subversions behind.
And Ellipses is exported from icons.ts, not aliases.ts.

@justuskilianwolff
Copy link

justuskilianwolff commented Apr 7, 2024

@karsa-mistmere I deleted my node_modulesdir and ran npm install, npm updatebut still can't find ellipsis. That line you highlighted is not found in my aliases.d.ts. I am running

"node_modules/lucide-svelte": {
			"version": "0.316.0",
			"resolved": "https://registry.npmjs.org/lucide-svelte/-/lucide-svelte-0.316.0.tgz",
			"integrity": "sha512-6mtBw/aU1IIVXfN6AXLSwsbeCFX/2/tTy84rrDTDsOq7BEijFbvObQsPEWPxJ0EyCjUXOYfAvfkZzMosYjyGqA==",
			"peerDependencies": {
				"svelte": ">=3 <5"
			}
		},

Also the paths look different in my version? Screenshot 2024-04-07 at 13 05 54

Please upgrade, you're like 50 subversions behind. And Ellipses is exported from icons.ts, not aliases.ts.

It's probably my limited npm and svelte knowledge, however, I did upgrade and and still can't find it...
Screenshot 2024-04-07 at 13 17 56
I'd appreciate any additional hint (above is my file structure after again deleting the modules and reinstalling with 0.365.0).

Screenshot 2024-04-07 at 13 20 36

@karsa-mistmere
Copy link
Member

@karsa-mistmere I deleted my node_modulesdir and ran npm install, npm updatebut still can't find ellipsis. That line you highlighted is not found in my aliases.d.ts. I am running

"node_modules/lucide-svelte": {
			"version": "0.316.0",
			"resolved": "https://registry.npmjs.org/lucide-svelte/-/lucide-svelte-0.316.0.tgz",
			"integrity": "sha512-6mtBw/aU1IIVXfN6AXLSwsbeCFX/2/tTy84rrDTDsOq7BEijFbvObQsPEWPxJ0EyCjUXOYfAvfkZzMosYjyGqA==",
			"peerDependencies": {
				"svelte": ">=3 <5"
			}
		},

Also the paths look different in my version? Screenshot 2024-04-07 at 13 05 54

Please upgrade, you're like 50 subversions behind. And Ellipses is exported from icons.ts, not aliases.ts.

It's probably my limited npm and svelte knowledge, however, I did upgrade and and still can't find it... Screenshot 2024-04-07 at 13 17 56 I'd appreciate any additional hint (above is my file structure after again deleting the modules and reinstalling with 0.365.0).

Screenshot 2024-04-07 at 13 20 36

It's within the icons folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants