Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon request: laptop #77

Closed
ghost opened this issue Sep 20, 2020 · 18 comments
Closed

Icon request: laptop #77

ghost opened this issue Sep 20, 2020 · 18 comments
Labels
🙌 icon request

Comments

@ghost
Copy link

ghost commented Sep 20, 2020 •
edited by ghost

Icon Request

  • Icon name: laptop
  • Use case: for laptop computers
  • Screenshots of similar icons:
    image

I created the icon on my own, I can send the SVG file
@ghost ghost added the 🙌 icon request label Sep 20, 2020
@ericfennis
Copy link
Member

@delnyn Welcome to featherity!
Nice request, we will look in to it!

@locness3
Copy link
Contributor

Nice to see you here @delnyn ! Please do send the svg :)

@ghost
Copy link
Author

ghost commented Sep 21, 2020 •
edited by ghost

Thanks!
Sadly GitHub doesn't support svg file...
So I just put it in a repo so you can download it.

@ericfennis
Copy link
Member

What do think of this?
image

100%
image

@ghost
Copy link
Author

ghost commented Sep 22, 2020 •
edited by ghost

In my opinion, the first idea looks better, though the second one would be more "guidelines-friendly"...
I tried to respect the guidelines (talking about the 2px border radius for 90° angles) in my first try but it was looking kinda weird.

I suggest we try different things before deciding.

@ericfennis
Copy link
Member

ericfennis commented Sep 26, 2020 •
edited

@delnyn I totally agree to explore more things and decide which one fits the best, but following the guidelines is necessary to match it with the other icons. So please follow them.
Also I recommend you to try your icon design next to the existing device icons, like I post here above.

Feel free to post your progress in our discord channel to get more direct feedback from the community.

@ghost
Copy link
Author

ghost commented Sep 26, 2020

@ericfennis Thank you very much!

@ghost
Copy link
Author

ghost commented Oct 2, 2020 •
edited by ghost

I had this idea but I'm not sure about it
image

@locness3
Copy link
Contributor

locness3 commented Oct 3, 2020

It looks more in line with Feather if distinct elements have some spacing between them

@ghost
Copy link
Author

ghost commented Oct 3, 2020 •
edited by ghost

@locness3 Well, those are not supposed to be distinct elements (cf inbox and hard drive icons)
[edit] I just realized those icons don't have rounded corners at the "join" (not sure about this word - I'm french help me)
image

@ghost
Copy link
Author

ghost commented Oct 3, 2020

What about this?
image

@ericfennis
Copy link
Member

ericfennis commented Oct 3, 2020 •
edited

@delnyn Nice work. I like this one better, can you post an image next to the other device?Like I posted before. So we can check if it match with the devices 😀

@ghost
Copy link
Author

ghost commented Oct 3, 2020

image

@ericfennis
Copy link
Member

Nice work! I think the screen height can a bit higher 🤔

@ghost
Copy link
Author

ghost commented Oct 7, 2020 •
edited by ghost

1px higher @ericfennis
image

@ericfennis
Copy link
Member

ericfennis commented Oct 8, 2020 •
edited

Nice I think this looks better!
Can you make a pull-request?

If you're not familiar with that process, just say we can help you!

@locness3
Copy link
Contributor

locness3 commented Oct 8, 2020

You mean "process"?

@ghost
Copy link
Author

ghost commented Oct 8, 2020

#88

@ericfennis ericfennis mentioned this issue Oct 13, 2020
Merged
@ghost ghost closed this as completed Oct 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙌 icon request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericfennis @locness3