Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

growth_term calculation error #2

Closed
inspirit opened this issue Mar 16, 2022 · 4 comments
Closed

growth_term calculation error #2

inspirit opened this issue Mar 16, 2022 · 4 comments

Comments

@inspirit
Copy link

inspirit commented Mar 16, 2022 •
edited

ETSformer-pytorch/etsformer_pytorch/etsformer_pytorch.py

Lines 233 to 235 in e1d8514

growth = self.to_growth(latent_growth)
growth_smoothing_weights = (1 - alpha) ** powers
growth_term = conv1d_fft(x, Aes_weights)

It looks like you are not using growth and growth_smoothing_weightsto calculate growth_term
@lucidrains
Copy link
Owner

@inspirit 🤦‍♂️ oh yes, thank you for catching that! ace5ac9 🙏

@lucidrains
Copy link
Owner

@inspirit do let me know if you get positive results with this architecture, and if you end up benchmarking this against vanilla ETS (which was not in the paper) 🙏

@inspirit
Copy link
Author

inspirit commented Mar 17, 2022 •
edited

@inspirit 🤦‍♂️ oh yes, thank you for catching that! ace5ac9 🙏

it looks like
growth = self.to_growth(latent_growth)
still not used for anything :)

@lucidrains
Copy link
Owner

@inspirit 2e0d465 oops lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucidrains @inspirit