New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value function input #28

Closed

kkissmart opened this issue Feb 12, 2023 · 1 comment

kkissmart commented Feb 12, 2023 •

edited

Loading

Author

kkissmart commented Feb 12, 2023

also I think this is a bug

PaLM-rlhf-pytorch/palm_rlhf_pytorch/ppo.py

Line 604 in 9b3caf5

action_log_prob = log_prob(action_prob, actions)

action_prob is bsz * (state_len+action_len), actions is bsz* action_len

kkissmart closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment