Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong variable #17

Closed
ben10ben opened this issue Nov 27, 2023 · 3 comments
Closed

wrong variable #17

ben10ben opened this issue Nov 27, 2023 · 3 comments

Comments

@ben10ben
Copy link

Hi, there is an issue with iTransformer.py in line 210 and the other iTransformer implementations as well.

assert targets.shape == pred_list.shape

should be changed to

assert target.shape == pred.shape

lucidrains added a commit that referenced this issue Nov 27, 2023
@lucidrains
Copy link
Owner

lucidrains commented Nov 27, 2023

@ben10ben hey! thanks for catching this, should be fixed

have you tried any of the variants? for your work or otherwise?

@ben10ben
Copy link
Author

Tried the iTransformer1d with RevIn for the electricity dataset. My implementation is similar to the initial paper but uses 10% more time series.

lookback: 96
pred_length: 96

iTransformer paper MSE: 0.148

train MSE: 0.116, Epoch=10
test MSE: 0.169

Did not get around to doing hyperparameter tuning, but I will hopefully be able to publish a paper beginning of next year.

@lucidrains
Copy link
Owner

nice! looks great! thank you for relaying 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants