Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in original google-research implementation #50

Closed
gulnazaki opened this issue Dec 22, 2020 · 3 comments
Closed

Bug fix in original google-research implementation #50

gulnazaki opened this issue Dec 22, 2020 · 3 comments

Comments

@gulnazaki
Copy link
Contributor

gulnazaki commented Dec 22, 2020

Hey there,

I've seen that a significant bug regarding the data_normalizer has been recently fixed in the original implementation in case you haven't checked it yet. I see it exists here too, since you ported the code.

google-research/google-research@b09ac83

@lucidrains
Copy link
Owner

@gulnazaki haha, I ported over their Jax code, so it should be fine :) that's their new tensorflow implementation

@lucidrains
Copy link
Owner

@gulnazaki thanks for letting me know!

btw, new follow-up paper for Performer! https://arxiv.org/abs/2012.11346

tldr: sorta-gradient checkpointing along the sequence dimension

@gulnazaki
Copy link
Contributor Author

Oh yes, I am sorry I only had a quick look at it. I understand they fixed the tf implementation to match the one in jax.

Cool paper also, now the sky is the limit 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants