Custom position offset when rotating queries or keys #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library seems to assume that queries and keys are left-aligned position-wise e.g.
where
p_i
are corresponding positions. This is enforced by starting the sequence of positions always from0
withtorch.arange(seq_len)
here. Applications like Perceiver AR, however, require a position-wise right-alignment e.g.This pull requests allows to specify a start position for queries and or keys to enable alignments other than
left-alignments. For example
prints the following relative position embedding
(diagonal of 1s right-aligned) whereas the default behavior
would print
(diagonal of 1s left-aligned).