Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire codes heuristic is replacing inputs #13

Closed
kashif opened this issue Dec 22, 2021 · 2 comments
Closed

Expire codes heuristic is replacing inputs #13

kashif opened this issue Dec 22, 2021 · 2 comments

Comments

@kashif
Copy link
Contributor

kashif commented Dec 22, 2021

Thanks for the implementation!

One question, should this

vector-quantize-pytorch/vector_quantize_pytorch/vector_quantize_pytorch.py

Line 177 in ebce893

self.expire_codes_(x)

be actually self.expire_codes_(quantize)?
@lucidrains
Copy link
Owner

@kashif Hi Kashif, I don't believe so, because I think the logic is to replace some of the dead codes with randomly chosen vectors from the current batch

@kashif
Copy link
Contributor Author

kashif commented Dec 22, 2021

Hmm I see thanks

@kashif kashif closed this as completed Dec 22, 2021
@liangcl0928 liangcl0928 mentioned this issue Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kashif @lucidrains