New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing parameter of beta #22
Comments
@Corleone-Huang Hello Corleone! So the |
Hi @lucidrains, seems that the commitment loss in your code refers only to the first term of the equation:
Does the second term appears in you code somewhere? If it does, can you please help me find it? I tried and found no references to it. If it doesn't, what "moves" the codebook towards the encoder's output? The commit loss seems to "move" only the encoder outputs. I'm asking beacsue I'm trying to train RVQ+Decoder on top of a fixed pre trained Encoder (without fine tune the encoder). And it seems that the commit loss is just getting bigger. |
In this repository, the codebook is updated based on exponential moving averages. |
Hi, in the original VQVAE paper, the commit_loss is defined as
where the beta is usually to be 0.25. But the commit_loss is defined as the following in your implementation:
So I wonder if the parameter beta is set to be 1 by default or if the second term is missing? Thank you very much.
The text was updated successfully, but these errors were encountered: